Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify sources of voluntary disruptions #26840

Merged
merged 1 commit into from
May 16, 2021
Merged

Clarify sources of voluntary disruptions #26840

merged 1 commit into from
May 16, 2021

Conversation

mltsy
Copy link
Contributor

@mltsy mltsy commented Mar 4, 2021

See issue #22391

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. language/en Issues or PRs related to English language labels Mar 4, 2021
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 4, 2021
@mltsy
Copy link
Contributor Author

mltsy commented Mar 4, 2021

Okay, I've signed the CLA and am using the correct e-mail address on the commit now...I did just sign it 30 minutes ago... is there a way to re-trigger the CLA check?

@netlify
Copy link

netlify bot commented Mar 4, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 21b1e83

https://deploy-preview-26840--kubernetes-io-master-staging.netlify.app

@RA489
Copy link

RA489 commented Mar 8, 2021

Okay, I've signed the CLA and am using the correct e-mail address on the commit now...I did just sign it 30 minutes ago... is there a way to re-trigger the CLA check?

/check-cla

@mltsy
Copy link
Contributor Author

mltsy commented Mar 8, 2021

/check-cla

@mltsy
Copy link
Contributor Author

mltsy commented Mar 8, 2021

Trying again, after connecting my Github account:
/check-cla

Arhell
Arhell reviewed Mar 24, 2021
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About CLA, check please
https://github.com/kubernetes/community/blob/master/CLA.md

@mltsy
Copy link
Contributor Author

mltsy commented Mar 24, 2021

Well I've submitted a support request, because I've followed all the instructions there and can't figure out what the problem is. If someone wants to just take this minor change and submit it themselves, please feel free! 😅

@kbhawkey
Copy link
Contributor

@mltsy , It is not clear what is happening with the CLA.
You could open a new PR (with these changes)?

/close

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 23, 2021
@k8s-ci-robot
Copy link
Contributor

@kbhawkey: Closed this PR.

In response to this:

@mltsy , It is not clear what is happening with the CLA.
You could open a new PR (with these changes)?

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kbhawkey
Copy link
Contributor

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Apr 23, 2021
@k8s-ci-robot
Copy link
Contributor

@kbhawkey: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kbhawkey
Copy link
Contributor

Here you go

@kbhawkey
Copy link
Contributor

Page preview:
https://deploy-preview-26840--kubernetes-io-master-staging.netlify.app/docs/concepts/workloads/pods/disruptions/

@kbhawkey
Copy link
Contributor

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 23, 2021
@kbhawkey
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c95a15c075ce454d453c2380677792ffb8cddb32

@mltsy
Copy link
Contributor Author

mltsy commented Apr 23, 2021

Ah! Well that was interesting 😄 Thanks!

irvifa
irvifa reviewed May 16, 2021
View reviewed changes
Copy link
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2ef52e5 into kubernetes:master May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irvifa irvifa irvifa left review comments

@Arhell Arhell Arhell left review comments

@davidopp davidopp Awaiting requested review from davidopp

@foxish foxish Awaiting requested review from foxish

Assignees

@kbhawkey kbhawkey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mltsy @k8s-ci-robot @RA489 @kbhawkey @irvifa @Arhell